-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying args to be passed to kustomize build #7414
Merged
tejal29
merged 9 commits into
GoogleContainerTools:main
from
MarlonGamez:kustomize-build-args
May 19, 2022
Merged
feat: allow specifying args to be passed to kustomize build #7414
tejal29
merged 9 commits into
GoogleContainerTools:main
from
MarlonGamez:kustomize-build-args
May 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7414 +/- ##
==========================================
- Coverage 70.48% 66.48% -4.00%
==========================================
Files 515 570 +55
Lines 23150 27555 +4405
==========================================
+ Hits 16317 18321 +2004
- Misses 5776 7906 +2130
- Partials 1057 1328 +271
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Please rebase! |
tejal29
force-pushed
the
kustomize-build-args
branch
from
May 18, 2022 19:05
c1e8305
to
8c0c142
Compare
…/skaffold into kustomize-build-args
…onGamez/skaffold into kustomize-build-args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6721
Description
This PR ports over the config related to user specified
kustomize build
flags that existed in v1