Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying args to be passed to kustomize build #7414

Merged
merged 9 commits into from
May 19, 2022

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented May 16, 2022

Fixes: #6721

Description
This PR ports over the config related to user specified kustomize build flags that existed in v1

@MarlonGamez MarlonGamez requested a review from a team as a code owner May 16, 2022 21:01
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #7414 (6d7fc39) into main (290280e) will decrease coverage by 3.99%.
The diff coverage is 55.29%.

@@            Coverage Diff             @@
##             main    #7414      +/-   ##
==========================================
- Coverage   70.48%   66.48%   -4.00%     
==========================================
  Files         515      570      +55     
  Lines       23150    27555    +4405     
==========================================
+ Hits        16317    18321    +2004     
- Misses       5776     7906    +2130     
- Partials     1057     1328     +271     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 50.00% <0.00%> (-3.85%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 35.48% <11.11%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 55.93% <38.88%> (-20.54%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
... and 302 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tejal29
Copy link
Contributor

tejal29 commented May 18, 2022

Please rebase!

@tejal29 tejal29 force-pushed the kustomize-build-args branch from c1e8305 to 8c0c142 Compare May 18, 2022 19:05
@tejal29 tejal29 merged commit 0aeb284 into GoogleContainerTools:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold fix to upgrade from v2 to v3 configs
2 participants