Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wip: fix render to deploy - DON'T Merge #7326

Closed

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Apr 20, 2022

This is a prototype PR. This is a huge PR and needs to broken down in small chunks.
The main fixes for #7325 were

  1. Adding render in Runner.Deploy and Runner.DeployAndLog
  2. Getting rid of some complexity in AddTagsToPodSelector. The issue here was deployer was tracking original images in the manifests. If a built image was deployed then only it was watched.
    I don't see any issues with watching pod for all images built. By doing so, we could get rid of image parsing since the image in manifest did not have the image registry appended.

Small chunks

  • Add Render in Runner.Deploy and Runner.DeployAndLog. Render() to return a manifest list which can be piped to deployer. - chore: Fix render and deploy  #7329
  • Getting rid of some complexity in AddTagsToPodSelector - chore: Fix render and deploy  #7329
  • Remove Render from deployer Interface
  • Getting rid of hydrationDir for kubectl render init
  • Fixing all existing deploy/kubectl_test.go to first render and then deploy for new style manifests. They are good tests for backward compatibility. - chore: Fix render and deploy  #7329
    • Carry over reading remote manifests and manifests stored on GCS from deploy/kubectl to renderer/kubectl
  • Adding Renderer.MuteLogs functionality
  • Remove opts.SkipRender

@tejal29 tejal29 requested a review from a team as a code owner April 20, 2022 07:14
@tejal29 tejal29 requested a review from renzodavid9 April 20, 2022 07:14
@aaron-prindle
Copy link
Contributor

IIUC - this will also fix #7296

@MarlonGamez
Copy link
Contributor

@tejal29 will you be in charge of working on this? Or would you like someone else to take this up?

@tejal29 tejal29 mentioned this pull request May 6, 2022
8 tasks
@tejal29
Copy link
Contributor Author

tejal29 commented May 6, 2022

Lets close this one. I created a tracking issue here #7381

@tejal29 tejal29 closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants