chore(ko): Upgrade ko dependency to v0.11.2
#7224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `ko` build option to produce SBOM is disabled until we have a design for how this should work across Skaffold builders. Additional transitive dependencies (mainly authentication libraries for various image registries) means that the Skaffold binary grows by about 4.8MB. The change to labels_test.go works around the tests failing due to this change in `client-go` between `v0.21.3` and `v0.21.4`: kubernetes/client-go@c6c0ca0 That commit came from this k/k PR: kubernetes/kubernetes#102928 Related: GoogleContainerTools#7193 Tracking: GoogleContainerTools#7131
Codecov Report
@@ Coverage Diff @@
## main #7224 +/- ##
==========================================
- Coverage 70.48% 68.50% -1.98%
==========================================
Files 515 560 +45
Lines 23150 26504 +3354
==========================================
+ Hits 16317 18157 +1840
- Misses 5776 7093 +1317
- Partials 1057 1254 +197
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
LGTM, though it's a pity about the increased bloat :-( |
MarlonGamez
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
LGTM, thanks for consistently maintaining the ko builder @halvards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
kobuild option to produce SBOM is disabled until we have a design for how this should work across Skaffold builders.Additional transitive dependencies (mainly authentication libraries for various image registries) means that the Skaffold binary grows by about 4.8MB.
The change to labels_test.go works around the tests failing due to this change in
client-gobetweenv0.21.3andv0.21.4:kubernetes/client-go@c6c0ca0
That commit came from this k/k PR:
kubernetes/kubernetes#102928
Related: #7193
Tracking: #7131