Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix lts image build #7000

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Jan 10, 2022

This PR removes the release-lts make target's dependency on the cross target. The `cross target is being removed as a dependency from targets as it's functionality is being moved to kokoro.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #7000 (4c86d1c) into main (290280e) will decrease coverage by 1.71%.
The diff coverage is 56.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7000      +/-   ##
==========================================
- Coverage   70.48%   68.76%   -1.72%     
==========================================
  Files         515      554      +39     
  Lines       23150    25683    +2533     
==========================================
+ Hits        16317    17661    +1344     
- Misses       5776     6821    +1045     
- Partials     1057     1201     +144     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e89f28...4c86d1c. Read the comment docs.

@MarlonGamez MarlonGamez added kokoro:run runs the kokoro jobs on a PR kokoro:force-run forces a kokoro re-run on a PR and removed kokoro:run runs the kokoro jobs on a PR labels Jan 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jan 11, 2022
@tejal29 tejal29 merged commit 8cd8b69 into GoogleContainerTools:main Jan 11, 2022
MarlonGamez added a commit that referenced this pull request Jan 13, 2022
MarlonGamez added a commit that referenced this pull request Jan 26, 2022
gsquared94 pushed a commit that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants