feat(ko): Enable templating of labels and env
#6944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halvards
force-pushed
the
ko-envvar-image-labels
branch
from
d586ccd
to
067e5f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #6944 +/- ##
==========================================
- Coverage 70.48% 68.83% -1.66%
==========================================
Files 515 551 +36
Lines 23150 25324 +2174
==========================================
+ Hits 16317 17431 +1114
- Misses 5776 6716 +940
- Partials 1057 1177 +120
Continue to review full report at Codecov.
|
tejal29
reviewed
Dec 9, 2021
| bo, err := buildOptions(&test.artifact, test.runMode) | ||
| os.Setenv(testKoBuildOptionsEnvVar, test.envVarValue) | ||
| gotBo, err := buildOptions(&test.artifact, test.runMode) | ||
| os.Unsetenv(testKoBuildOptionsEnvVar) |
| ArtifactType: latestV1.ArtifactType{ | ||
| KoArtifact: &latestV1.KoArtifact{ | ||
| Dir: "my-go-mod-is-here", | ||
| envVarValue: "baz", |
There was a problem hiding this comment.
shd we add a test case for {{.Env.baz}} here?
This change enables `ko` builder users to substitute environment variable values in the `labels` and `env` config fields. These fields are used for image labels and build-time environment variables, respectively. Envvar templating of image labels can be used to add information such as the Git commit SHA to the image, see GoogleContainerTools#6916. Also, environment variable expansion of `flags` and `ldflags` in the `ko` builder configuration now supports Skaffold's templating syntax, for consistency. For backwards compatibility, `ko`'s templating syntax still works with `flags` and `ldflags`: Skaffold: `{{.FOO}}` `ko`: `{{.Env.FOO}}` Tracking: GoogleContainerTools#6041 Fixes: GoogleContainerTools#6916
halvards
force-pushed
the
ko-envvar-image-labels
branch
from
067e5f7
to
fd5150f
Compare
tejal29
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables
kobuilder users to substitute environment variable values in thelabelsandenvconfig fields.These fields are used for image labels and build-time environment variables, respectively.
Envvar templating of image labels can be used to add information such as the Git commit SHA to the image, see #6916.
Also, environment variable expansion of
flagsandldflagsin thekobuilder configuration now supports Skaffold's templating syntax, for consistency.For backwards compatibility,
ko's templating syntax still works withflagsandldflags:Skaffold:
{{.FOO}}ko:{{.Env.FOO}}Tracking: #6041
Fixes: #6916