Refine ko builder behavior for main packages #6437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decide on how ko builder users should specify the location of `package main` for their images. Previous discussion: GoogleContainerTools#6054 (comment) Tracking: GoogleContainerTools#6041 Related: GoogleContainerTools#6054, GoogleContainerTools#6286
Codecov Report
@@ Coverage Diff @@
## main #6437 +/- ##
==========================================
+ Coverage 70.40% 70.41% +0.01%
==========================================
Files 505 505
Lines 22840 22840
==========================================
+ Hits 16080 16083 +3
+ Misses 5708 5705 -3
Partials 1052 1052
Continue to review full report at Codecov.
|
tejal29
reviewed
Aug 16, 2021
| @@ -263,6 +291,13 @@ Adding the ko builder requires making config changes to the Skaffold schema. | |||
| // You can override this value by setting the `SOURCE_DATE_EPOCH` | |||
| // environment variable. | |||
| SourceDateEpoch uint64 `yaml:"sourceDateEpoch,omitempty"` | |||
|
|
|||
| // Target is the location of the main package. | |||
| // If target is specified as a relative path, it is relative to the `context` directory. | |||
There was a problem hiding this comment.
Wld ko error out if two main are found in the context dir?
Clarify how a blank value works, and also how users can use a pattern with wildcards.
|
Thanks @tejal29! I pushed a commit with an improved explanation. |
tejal29
approved these changes
Aug 16, 2021
|
Thanks for the quick turn-around! |
halvards
added a commit
to halvards/skaffold
that referenced
this pull request
Aug 17, 2021
This implements support for the Target config field for the ko builder. The Target field allows users to specify a target for `go build`. This is necessary where the main package is not in the context directory. Tracking: GoogleContainerTools#6041 Related: GoogleContainerTools#6054, GoogleContainerTools#6437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decide on how ko builder users should specify the location of
package main.Previous discussion: #6054 (comment)
Tracking: #6041
Related: #6054, #6286