Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable k3d integration tests #6171

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Jul 8, 2021

k3d integration tests have been failing with an error that seems to be unrelated to skaffold code, and it's causing CI to fail on many unrelated PRs. Let's disable the tests until we can diagnose and fix the issue.

@nkubala nkubala requested a review from a team as a code owner July 8, 2021 23:07
@nkubala nkubala requested a review from gsquared94 July 8, 2021 23:07
@google-cla google-cla bot added the cla: yes label Jul 8, 2021
@nkubala
Copy link
Contributor Author

nkubala commented Jul 8, 2021

ref k3d-io/k3d#671

@nkubala nkubala enabled auto-merge (squash) July 8, 2021 23:07
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #6171 (1e59747) into master (c2b6deb) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6171      +/-   ##
==========================================
- Coverage   69.34%   69.29%   -0.06%     
==========================================
  Files         481      482       +1     
  Lines       18492    18523      +31     
==========================================
+ Hits        12824    12836      +12     
- Misses       4716     4733      +17     
- Partials      952      954       +2     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 78.13% <0.00%> (-1.40%) ⬇️
pkg/skaffold/event/v2/render.go 23.80% <0.00%> (ø)
pkg/skaffold/event/v2/metadata.go 89.33% <0.00%> (+0.14%) ⬆️
pkg/skaffold/event/v2/event.go 80.48% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b6deb...1e59747. Read the comment docs.

@nkubala nkubala merged commit 1970818 into GoogleContainerTools:master Jul 9, 2021
@nkubala nkubala deleted the disable-k3d branch July 9, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants