Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BuildSubtaskEvent ID setting/handling #6167

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5368 #5370

Description
Changes the ID field BuildSubtaskEvents to be the artifact name, rather than an integer corresponding to the artifact name. This makes the code more simple and easier, especially when it comes to tying to the skaffoldLogEvent output

@MarlonGamez MarlonGamez requested a review from a team as a code owner July 8, 2021 20:27
@MarlonGamez MarlonGamez requested a review from briandealwis July 8, 2021 20:27
@google-cla google-cla bot added the cla: yes label Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #6167 (3f58723) into master (a4cf386) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6167   +/-   ##
=======================================
  Coverage   69.36%   69.36%           
=======================================
  Files         481      481           
  Lines       18480    18475    -5     
=======================================
- Hits        12819    12816    -3     
+ Misses       4706     4705    -1     
+ Partials      955      954    -1     
Impacted Files Coverage Δ
pkg/skaffold/runner/build.go 72.82% <ø> (-0.30%) ⬇️
pkg/skaffold/build/scheduler.go 92.18% <100.00%> (ø)
pkg/skaffold/event/v2/build.go 100.00% <100.00%> (+7.69%) ⬆️
pkg/skaffold/server/server.go 41.96% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4cf386...3f58723. Read the comment docs.

@tejal29 tejal29 merged commit 64bd534 into GoogleContainerTools:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants