add source file and module to config parsing error description #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6087 +/- ##
==========================================
+ Coverage 70.20% 70.22% +0.01%
==========================================
Files 475 475
Lines 18147 18165 +18
==========================================
+ Hits 12741 12757 +16
- Misses 4470 4472 +2
Partials 936 936
Continue to review full report at Codecov.
|
| // do not set a default deployer in a multi-config application. | ||
| if len(configs) > 1 { | ||
| return | ||
| } | ||
| // there always exists at least one config | ||
| defaults.SetDefaultDeployer(configs[0]) | ||
| defaults.SetDefaultDeployer(configs[0].SkaffoldConfig) |
There was a problem hiding this comment.
nit: Is it possilbe that configs[0] is nil? From the comment it doesn't seem possible, wanted to verify
|
Brilliant! Thanks for this! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5456
Description
This PR adds additional context to config-parsing errors like the file name and module name(if defined) or the index of the config.
User facing changes (remove if N/A)
Before:
After: