Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Helm image reference strategies #6017

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

briandealwis
Copy link
Member

Description
Improve Helm docs by updating the image reference strategies. Some of the text seems to pre-date the new helm strategy.

@briandealwis briandealwis requested a review from a team as a code owner June 15, 2021 15:42
@briandealwis briandealwis requested a review from nkubala June 15, 2021 15:42
@google-cla google-cla bot added the cla: yes label Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #6017 (0d7c48f) into master (7f754f6) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6017      +/-   ##
==========================================
- Coverage   70.79%   70.72%   -0.08%     
==========================================
  Files         462      462              
  Lines       17866    17887      +21     
==========================================
+ Hits        12649    12651       +2     
- Misses       4286     4304      +18     
- Partials      931      932       +1     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/diag/validator/pod.go 1.11% <0.00%> (-0.12%) ⬇️
pkg/skaffold/deploy/status/status_check.go 70.92% <0.00%> (+0.84%) ⬆️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f754f6...0d7c48f. Read the comment docs.

@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Jun 16, 2021
@container-tools-bot
Copy link

Please visit http://35.236.30.3:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jun 16, 2021
@briandealwis briandealwis merged commit 329a9c7 into GoogleContainerTools:master Jun 17, 2021
@briandealwis briandealwis deleted the helm-docs branch June 17, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants