Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear ApplicationLogEvent and SkaffoldLogEvent buffers on new dev iteration #5993

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Clear ApplicationLogEvent and SkaffoldLogEvent buffers on new dev iteration #5993

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
560bcc7
clear user application and skaffold logs on new dev iteration
MarlonGamez Jun 9, 2021
8f14bd0
use empty slice literals instead of nils
MarlonGamez Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/skaffold/event/v2/event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,12 @@ func AutoTriggerDiff(phase constants.Phase, val bool) (bool, error) {
}

func TaskInProgress(task constants.Phase, description string) {
// Special casing to increment iteration and clear application and skaffold logs
if task == constants.DevLoop {
handler.iteration++

handler.applicationLogs = nil
handler.skaffoldLogs = nil
}

handler.handleTaskEvent(&proto.TaskEvent{
Expand Down