Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET .csproj detection to init for buildpacks #5883

Merged
merged 2 commits into from
May 21, 2021

Conversation

briandealwis
Copy link
Member

Description
Reported by @viglesiasce: our buildpacks detection doesn't work for .NET projects.

No user doc since init for buildpacks is still behind a feature flag.

@briandealwis briandealwis requested a review from a team as a code owner May 21, 2021 03:28
@briandealwis briandealwis requested a review from nkubala May 21, 2021 03:28
@google-cla google-cla bot added the cla: yes label May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #5883 (366a224) into master (ff5038a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5883   +/-   ##
=======================================
  Coverage   70.91%   70.91%           
=======================================
  Files         447      447           
  Lines       16908    16908           
=======================================
  Hits        11990    11990           
  Misses       4028     4028           
  Partials      890      890           
Impacted Files Coverage Δ
pkg/skaffold/build/buildpacks/init.go 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5038a...366a224. Read the comment docs.

@briandealwis briandealwis enabled auto-merge (squash) May 21, 2021 13:40
Copy link

@sivakku sivakku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@briandealwis briandealwis merged commit c07a304 into GoogleContainerTools:master May 21, 2021
@briandealwis briandealwis deleted the bp-init-dotnet branch May 21, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants