Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Add render generator #5865

Merged
merged 1 commit into from
May 20, 2021

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented May 19, 2021

Related: #5673

Description
Generator reads the schema Render.Generate and parses the raw and kustomize resources based on render.generate.manifests.

@yuwenma yuwenma requested review from tejal29 and MarlonGamez May 19, 2021 20:41
@yuwenma yuwenma requested a review from a team as a code owner May 19, 2021 20:41
@google-cla google-cla bot added the cla: yes label May 19, 2021
@yuwenma yuwenma force-pushed the render-1-generator branch from 51be36d to 624cdb7 Compare May 19, 2021 21:35
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #5865 (c7bd42e) into master (7a2ba77) will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5865      +/-   ##
==========================================
+ Coverage   70.80%   70.82%   +0.02%     
==========================================
  Files         446      447       +1     
  Lines       16816    16869      +53     
==========================================
+ Hits        11906    11947      +41     
- Misses       4024     4031       +7     
- Partials      886      891       +5     
Impacted Files Coverage Δ
pkg/skaffold/deploy/kustomize/util.go 88.23% <ø> (ø)
pkg/skaffold/render/generate/generate.go 77.35% <77.35%> (ø)
pkg/skaffold/deploy/kustomize/kustomize.go 74.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2ba77...c7bd42e. Read the comment docs.

@yuwenma yuwenma force-pushed the render-1-generator branch from 624cdb7 to c7bd42e Compare May 19, 2021 22:46
@tejal29 tejal29 merged commit 4eb8930 into GoogleContainerTools:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants