[v3] Schema Version upgrading for v1 and v2. #5796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
requested review from
MarlonGamez and
tejal29
and removed request for
aaron-prindle
Codecov Report
@@ Coverage Diff @@
## master #5796 +/- ##
==========================================
+ Coverage 70.92% 70.95% +0.02%
==========================================
Files 438 438
Lines 16434 16477 +43
==========================================
+ Hits 11656 11691 +35
- Misses 3921 3926 +5
- Partials 857 860 +3
Continue to review full report at Codecov.
|
MarlonGamez
previously requested changes
May 6, 2021
1. Add upgrade func to v3alpha1 2. Enable schema parsing for v2 schemas (v3alpha*) 3. Compatibility check among v1 and v2 schemas 4. Update `skaffold fix` to avoid upgrading v1 schemas to v2 and vice versa. 5. Update the schemas usage in `hack`, `cmd/fix` `cmd/list` to hide v2 schemas from users.
tejal29
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5673
Description
skaffold fixto avoid upgrading v1 schemas to v2 and vice versa.hack,cmd/fixcmd/listto hide v2 schemas from users.