-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show update check message to users once in 24 hours #5795
Show update check message to users once in 24 hours #5795
Conversation
8a34a00
to
0e97ef8
Compare
0e97ef8
to
315b24e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5795 +/- ##
==========================================
- Coverage 70.95% 70.93% -0.02%
==========================================
Files 439 438 -1
Lines 16408 16434 +26
==========================================
+ Hits 11642 11658 +16
- Misses 3913 3920 +7
- Partials 853 856 +3
Continue to review full report at Codecov.
|
will do some manual testing and get back 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just a couple nits/q's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏼
Relates to #5711
Update check prompts are shown on every command run.
This could annoy the users and get them to switch off update checks.
In this PR
update
withlast-prompted
field.This does not change the existing update check behavior. See #5741 for that.
Testing done:
a) update check message is not shown.
b)
update-config
is not updated withlast-prompted
a) update message is shown
b)
update-config
is updated withlast-prompted
c) subsequent invocations don't display the update check messages.
d) Change the date to yesterday and make sure update message is displayed