Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo-fix #5772

Merged
merged 2 commits into from
May 5, 2021
Merged

Conversation

aleksandrOranskiy
Copy link
Contributor

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description
It's just a small typo fix.

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@aleksandrOranskiy aleksandrOranskiy requested a review from a team as a code owner May 3, 2021 17:53
@google-cla
Copy link

google-cla bot commented May 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #5772 (33e4ea2) into master (91c4480) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5772      +/-   ##
==========================================
+ Coverage   70.70%   70.79%   +0.08%     
==========================================
  Files         428      436       +8     
  Lines       16199    16356     +157     
==========================================
+ Hits        11454    11579     +125     
- Misses       3900     3923      +23     
- Partials      845      854       +9     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/build/jib/init.go 83.05% <0.00%> (-4.45%) ⬇️
pkg/skaffold/color/formatter.go 96.00% <0.00%> (-4.00%) ⬇️
pkg/skaffold/schema/profiles.go 88.46% <0.00%> (-1.15%) ⬇️
pkg/skaffold/build/jib/jib.go 69.46% <0.00%> (-1.08%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
pkg/skaffold/runner/tester.go 100.00% <0.00%> (ø)
pkg/skaffold/schema/errors/errors.go 100.00% <0.00%> (ø)
pkg/skaffold/inspect/types.go 45.45% <0.00%> (ø)
pkg/skaffold/inspect/profiles.go 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c4480...33e4ea2. Read the comment docs.

nkubala
nkubala previously requested changes May 3, 2021
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksandrOranskiy thanks for the fix! would you mind signing our CLA using the email you used to make this commit? i'll retrigger our integration tests to get CI green on here and then we can get this merged

docs/content/en/docs/pipeline-stages/builders/custom.md Outdated Show resolved Hide resolved
@google-cla google-cla bot added cla: yes and removed cla: no labels May 4, 2021
@aleksandrOranskiy
Copy link
Contributor Author

@googlebot I signed it!

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label May 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 5, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @aleksandrOranskiy :)

@MarlonGamez MarlonGamez dismissed nkubala’s stale review May 5, 2021 23:51

the requested change was made

@MarlonGamez MarlonGamez merged commit ce34201 into GoogleContainerTools:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants