[WIP][V3] Add the new schema v3alpha1. #5695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5695 +/- ##
==========================================
- Coverage 70.44% 70.21% -0.24%
==========================================
Files 413 415 +2
Lines 15934 16051 +117
==========================================
+ Hits 11225 11270 +45
- Misses 3877 3949 +72
Partials 832 832
Continue to review full report at Codecov.
|
This schema contains the main fields to support the new skaffold render and deployment, powered by kpt. Some config names may change based on the the user survey results. For reviewers: - `Render`: Top tier section. It contains the basic render functions `generate`, `validate` and `trasform`. It does not include the helmcharts (generate) and kpt package magement yet, which will be added on following CLs. - `Deploy`: Simplified. The deployers (helm, kubectl, kpt, kustomize) are removed. Some helm and kubectl features, and flags are not covered in the `deploy` section yet. Will be added in following CLs. - v2 and v3 versions are not compatible. So the `upgrade` functions do not need to change. But we will add more checks on other codes to guarantee the v2 and v3 are not mixed (especially in multi-config mode). - Generated doc via "go run hack/schemas/main.go".
gsquared94
reviewed
Apr 16, 2021
MarlonGamez
reviewed
Apr 20, 2021
There was a problem hiding this comment.
This is looking good, but we need to modify hack/check-samples here to not treat this config as the latest released one. Right now in hack/versions/cmd/latest-released/version.go it's grabbing the latest version by doing schema.SchemaVersions[len(schema.SchemaVersions)-2].APIVersion, which will hit v3alpha1 since that slice now looks like
...
{v2beta13.Version, v2beta13.NewSkaffoldConfig, true},
{v2beta14.Version, v2beta14.NewSkaffoldConfig, true},
{v3alpha1.Version, v3alpha1.NewSkaffoldConfig, false},
{latest.Version, latest.NewSkaffoldConfig, true},
}
yuwenma
changed the title
|
Deprecated. |
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5673
Description
his schema contains the main fields to support the new skaffold render and deployment, powered by kpt. Some config names may change based on the the user survey results.
For reviewers:
Render: Top tier section. It contains the basic render functionsgenerate,validateandtrasform. It does not include the helmcharts (generate) and kpt package magement yet, which will be added on following CLs.Deploy: Simplified. The deployers (helm, kubectl, kpt, kustomize) are removed. Some helm and kubectl features, and flags are not covered in thedeploysection yet. Will be added in following CLs.upgradefunctions do not need to change. But we will add more checks on other codes to guarantee the v2 and v3 are not mixed (especially in multi-config mode).