Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tutorial for buildpacks run image override #5409

Merged

Conversation

gsquared94
Copy link
Contributor

Fixes #4999
Reviving this from long ago. Adds a tutorial for overriding the run image used in buildpacks with another artifact image.
To test:

Open in Cloud Shell

@gsquared94 gsquared94 requested a review from a team as a code owner February 17, 2021 19:54
@google-cla google-cla bot added the cla: yes label Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #5409 (69e7007) into master (73d60cb) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5409      +/-   ##
==========================================
- Coverage   71.57%   71.36%   -0.21%     
==========================================
  Files         397      397              
  Lines       14434    14540     +106     
==========================================
+ Hits        10331    10377      +46     
- Misses       3335     3390      +55     
- Partials      768      773       +5     
Impacted Files Coverage Δ
pkg/skaffold/test/structure/structure.go 86.79% <0.00%> (-13.21%) ⬇️
pkg/skaffold/runner/new.go 67.58% <0.00%> (-1.70%) ⬇️
pkg/skaffold/schema/versions.go 82.41% <0.00%> (ø)
pkg/skaffold/test/structure/error.go 100.00% <0.00%> (ø)
pkg/skaffold/test/test.go
pkg/skaffold/test/error.go
pkg/skaffold/test/structure/types.go
pkg/skaffold/test/test_factory.go 78.94% <0.00%> (ø)
pkg/skaffold/schema/v2beta12/config.go 20.58% <0.00%> (ø)
pkg/skaffold/schema/v2beta12/upgrade.go 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d60cb...69e7007. Read the comment docs.

@gsquared94 gsquared94 added this to the v1.21.0-rc milestone Feb 18, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good tutorial imo, I like that it's short and simple :) I only found one issue with a file link but other than that I think it's good

codelab/03_buildpacks-runimage-override/tutorial.md Outdated Show resolved Hide resolved
@MarlonGamez MarlonGamez merged commit cac0c53 into GoogleContainerTools:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codelab that shows how to configure an arbitrary base image for a CNB stack
2 participants