Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dark mode option to skaffold website #5364

Closed
wants to merge 1 commit into from

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented Feb 8, 2021

Was wondering how to add dark mode to our docs website. WDYT? 🤷🏾‍♂️

image

image

link: http://34.94.21.130:1313

@gsquared94 gsquared94 requested a review from nkubala February 8, 2021 17:03
@gsquared94 gsquared94 requested a review from a team as a code owner February 8, 2021 17:03
@google-cla google-cla bot added the cla: yes label Feb 8, 2021
@gsquared94 gsquared94 added meta/docs-preview docs-modifications runs the docs preview service on the given PR and removed meta/docs-preview labels Feb 8, 2021
@container-tools-bot
Copy link

Please visit http://34.94.21.130:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #5364 (ccdffd1) into master (7af9979) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5364      +/-   ##
==========================================
- Coverage   71.61%   71.60%   -0.01%     
==========================================
  Files         394      394              
  Lines       14305    14305              
==========================================
- Hits        10244    10243       -1     
- Misses       3307     3308       +1     
  Partials      754      754              
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af9979...ccdffd1. Read the comment docs.

@MarlonGamez
Copy link
Contributor

Looks cool, although I'm having some weird issues where things take a second to render when scrolling in dark mode. This doesn't seem to happen in light mode
Screen Shot 2021-02-08 at 9 54 00 AM
Screen Shot 2021-02-08 at 9 54 30 AM

@briandealwis
Copy link
Member

I see a lot of flicker/lag too. I'm leaning towards 👎 for now.

@briandealwis
Copy link
Member

There's an open request on docsy: google/docsy#331

@gsquared94 gsquared94 closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants