Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass correct build args to CreateDockerTarContext #4768

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

gsquared94
Copy link
Contributor

Modified function parameters for CreateDockerTarContext so that we can pass in the updated build args.

@gsquared94 gsquared94 requested a review from a team as a code owner September 10, 2020 05:56
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #4768 into master will increase coverage by 0.04%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4768      +/-   ##
==========================================
+ Coverage   73.79%   73.83%   +0.04%     
==========================================
  Files         345      347       +2     
  Lines       13744    13755      +11     
==========================================
+ Hits        10142    10156      +14     
+ Misses       2970     2967       -3     
  Partials      632      632              
Impacted Files Coverage Δ
pkg/skaffold/build/cluster/kaniko.go 0.00% <0.00%> (ø)
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/schema/v2beta6/upgrade.go 100.00% <ø> (ø)
pkg/skaffold/schema/versions.go 82.75% <ø> (ø)
pkg/skaffold/diagnose/diagnose.go 58.33% <100.00%> (ø)
pkg/skaffold/docker/context.go 80.00% <100.00%> (ø)
pkg/skaffold/docker/image.go 73.36% <100.00%> (ø)
pkg/skaffold/schema/v2beta7/config.go 100.00% <100.00%> (ø)
pkg/skaffold/schema/v2beta7/upgrade.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b1f940...4add95c. Read the comment docs.

@nkubala nkubala merged commit ab91350 into GoogleContainerTools:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants