Add option for helm deployments to create namespace #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsquared94
reviewed
Sep 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #4765 +/- ##
==========================================
+ Coverage 73.79% 73.85% +0.06%
==========================================
Files 345 347 +2
Lines 13744 13757 +13
==========================================
+ Hits 10142 10160 +18
+ Misses 2970 2965 -5
Partials 632 632
Continue to review full report at Codecov.
|
gsquared94
reviewed
Sep 14, 2020
pkg/skaffold/deploy/helm_test.go
Outdated
| @@ -272,6 +272,7 @@ var testTwoReleases = latest.HelmDeploy{ | |||
| }}, | |||
| } | |||
|
|
|||
| var crateNamespaceFlag = true | |||
There was a problem hiding this comment.
Suggested change
| var crateNamespaceFlag = true | |
| var createNamespaceFlag = true |
There was a problem hiding this comment.
@gsquared94 thanks for catching this. fixed
gsquared94
reviewed
Sep 14, 2020
pkg/skaffold/deploy/helm_test.go
Outdated
| @@ -284,7 +285,7 @@ var testDeployCreateNamespaceConfig = latest.HelmDeploy{ | |||
| "some.key": "somevalue", | |||
| }, | |||
| Namespace: "testReleaseNamespace", | |||
| CreateNamespace: true, | |||
| CreateNamespace: &crateNamespaceFlag, | |||
There was a problem hiding this comment.
Suggested change
| CreateNamespace: &crateNamespaceFlag, | |
| CreateNamespace: &createNamespaceFlag, |
gsquared94
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4482
Description
This PR adds the ability to create a namespace for Helm deploy command if Helm version is 3.2+.