Re-enable survey prompt

[nkubala]

fixes #4630

also, slightly change wording and add a bit of color.

[tstromberg]

Which commands will this be enabled for? I want to make sure that it's only for a specific set of white-listed commands where it makes the most sense to show, rather than "help" and "version".

[tejal29]

Which commands will this be enabled for? I want to make sure that it's only for a specific set of white-listed commands where it makes the most sense to show, rather than "help" and "version".

Currently, we are enabling this for all commands.

[nkubala]

Which commands will this be enabled for? I want to make sure that it's only for a specific set of white-listed commands where it makes the most sense to show, rather than "help" and "version".

this is a good point, showing the survey text for help really makes no sense. I think we probably only want to show it for "interactive" subcommands - dev, debug, run, build, deploy, maybe render. whereas it might not make sense on init, and definitely doesn't make sense on credits or version.

i'll update this PR and list out the commands it's enabled for once i do.

[nkubala]

whoops, totally forgot we added this already: #4622

fixing the tests then this should be ready

[codecov]

Codecov Report

Merging #4764 into master will increase coverage by 0.05%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #4764      +/-   ##
==========================================
+ Coverage   73.79%   73.84%   +0.05%     
==========================================
  Files         345      347       +2     
  Lines       13744    13753       +9     
==========================================
+ Hits        10142    10156      +14     
+ Misses       2970     2965       -5     
  Partials      632      632              

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/cmd.go	68.34% <0.00%> (ø)
pkg/skaffold/schema/latest/config.go	100.00% <ø> (ø)
pkg/skaffold/schema/v2beta6/upgrade.go	100.00% <ø> (ø)
pkg/skaffold/schema/versions.go	82.75% <ø> (ø)
pkg/skaffold/schema/v2beta7/config.go	100.00% <100.00%> (ø)
pkg/skaffold/schema/v2beta7/upgrade.go	100.00% <100.00%> (ø)
pkg/skaffold/survey/survey.go	52.94% <100.00%> (+7.48%)	⬆️
pkg/skaffold/deploy/helm.go	78.77% <0.00%> (-0.26%)	⬇️
pkg/skaffold/docker/context.go	80.00% <0.00%> (ø)
pkg/skaffold/build/cluster/kaniko.go	0.00% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b1f940...f1d416c. Read the comment docs.

addressed