Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass a context to DefaultAuthHelper.GetAllConfigs() #4760

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Pass a context to DefaultAuthHelper.GetAllConfigs() #4760

merged 2 commits into from
Sep 7, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Sep 3, 2020

Signed-off-by: David Gageot [email protected]

@dgageot dgageot requested a review from a team as a code owner September 3, 2020 07:26
@dgageot dgageot requested a review from MarlonGamez September 3, 2020 07:26
@codecov
Copy link

codecov bot commented Sep 3, 2020 •
edited
Loading

Codecov Report

Merging #4760 into master will increase coverage by 0.08%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4760      +/-   ##
==========================================
+ Coverage   73.70%   73.79%   +0.08%     
==========================================
  Files         345      345              
  Lines       13741    13744       +3     
==========================================
+ Hits        10128    10142      +14     
+ Misses       2981     2970      -11     
  Partials      632      632
Impacted Files Coverage Δ
pkg/skaffold/docker/auth.go 77.46% <87.50%> (+21.32%) ⬆️
pkg/skaffold/docker/image.go 73.36% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36284dd...8de9c02. Read the comment docs.

@dgageot
Add tests
8de9c02 
Signed-off-by: David Gageot <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 7, 2020
@dgageot
Copy link
Contributor Author

dgageot commented Sep 7, 2020

kokoro failure is unrelated.

@dgageot dgageot merged commit 4cccbd6 into GoogleContainerTools:master Sep 7, 2020
@fmotrifork fmotrifork mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@MarlonGamez MarlonGamez Awaiting requested review from MarlonGamez

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @briandealwis @googlebot