Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable survey prompt until the next release #4629

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Aug 4, 2020

this will disable showing the survey prompt completely until v1.14.0 is released

@nkubala nkubala requested a review from a team as a code owner August 4, 2020 19:39
@nkubala nkubala requested a review from briandealwis August 4, 2020 19:39
@tstromberg
Copy link
Contributor

Shouldn't a test fail?

Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this manually and it appears to work properly.

@nkubala
Copy link
Contributor Author

nkubala commented Aug 4, 2020

the tests won't fail because i put this logic where the survey actually gets shown, not where we check whether we should show it. this guarantees it will never get show, even if skaffold thinks it should/will.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #4629 into master will decrease coverage by 0.02%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4629      +/-   ##
==========================================
- Coverage   73.18%   73.16%   -0.03%     
==========================================
  Files         337      337              
  Lines       13261    13266       +5     
==========================================
+ Hits         9705     9706       +1     
- Misses       2947     2950       +3     
- Partials      609      610       +1     
Impacted Files Coverage Δ
pkg/skaffold/survey/survey.go 45.45% <20.00%> (-7.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe8a1f...27c3dc1. Read the comment docs.

@tejal29 tejal29 merged commit 3f842dd into GoogleContainerTools:master Aug 4, 2020
@nkubala nkubala deleted the disable-survey branch August 4, 2020 20:41
@AndiDog
Copy link
Contributor

AndiDog commented Aug 5, 2020

Not sure if you found the root cause already, but here's a hint. For v1.13, I fixed this by running skaffold completion bash >/usr/local/etc/bash_completion.d/skaffold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants