-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable survey prompt until the next release #4629
Conversation
Shouldn't a test fail? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this manually and it appears to work properly.
the tests won't fail because i put this logic where the survey actually gets shown, not where we check whether we should show it. this guarantees it will never get show, even if skaffold thinks it should/will. |
Codecov Report
@@ Coverage Diff @@
## master #4629 +/- ##
==========================================
- Coverage 73.18% 73.16% -0.03%
==========================================
Files 337 337
Lines 13261 13266 +5
==========================================
+ Hits 9705 9706 +1
- Misses 2947 2950 +3
- Partials 609 610 +1
Continue to review full report at Codecov.
|
Not sure if you found the root cause already, but here's a hint. For v1.13, I fixed this by running |
this will disable showing the survey prompt completely until
v1.14.0
is released