Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'survey' command text #4625

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

tstromberg
Copy link
Contributor

Old Behavior

skaffold help survey

Show Skaffold survey url

Usage:
  skaffold survey [flags] [options]

Use "skaffold options" for a list of global command-line options (applies to all commands).

skaffold survey

Thank you for offering your feedback on Skaffold! Understanding your experiences and opinions helps us make Skaffold better for you and other users.
   Our survey can be found here: https://forms.gle/BMTbGQXLWSdn7vEs6

To permanently disable the survey prompt, run:
   skaffold config set --survey --global disable-prompt true

New behavior

skaffold help survey

Opens a web browser to fill out the Skaffold survey

Usage:
  skaffold survey [flags] [options]

Use "skaffold options" for a list of global command-line options (applies to all commands).

skaffold survey

Thank you for offering your feedback on Skaffold! Understanding your experiences and opinions helps us make Skaffold better for you and other users.

Skaffold will now attempt to open the survey in your default web browser. You may also manually open it using this link:

https://forms.gle/BMTbGQXLWSdn7vEs6

To permanently disable the survey prompt, run:
   skaffold config set --survey --global disable-prompt true

@tstromberg tstromberg requested a review from a team as a code owner August 4, 2020 17:29
@tstromberg tstromberg requested a review from tejal29 August 4, 2020 17:29
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #4625 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4625   +/-   ##
=======================================
  Coverage   73.18%   73.18%           
=======================================
  Files         337      337           
  Lines       13261    13261           
=======================================
  Hits         9705     9705           
  Misses       2947     2947           
  Partials      609      609           
Impacted Files Coverage Δ
pkg/skaffold/survey/survey.go 52.94% <ø> (ø)
cmd/skaffold/app/cmd/survey.go 57.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6520ff3...6a016f0. Read the comment docs.

@nkubala nkubala merged commit 9fe8a1f into GoogleContainerTools:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants