Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4614
#4588 added a new
TagPolicy
,CustomTagger
, which contains one or moreTaggerComponent
s, each of which itself is aTagPolicy
.since the
TagPolicy
was inlined, our schema generator was removing it from the generated definition properties - this was causing a nil pointer exception in the javascript.once this issue was fixed, we have another issue. our templater generates HTML for every schema definition, and nests HTML for every nested schema definition - this means that
TagPolicy
->CustomTagger
->TaggerComponent
->TagPolicy
causes an infinite loop in the schema generation.the fix here is to add a new yamlTag,
skipTrim
, which skips trimming off inlined definitions when set. additionally, our templater will now special caseTaggerComponent
and yield empty HTML rather than recurse into nested definitions, avoiding the infinite loop.NOTE: this will fail the schema version check, since this technically updates a released schema version. however, since this is just a yaml tag update and NOT a user facing change, I believe this should be safe. once this is merged to master, all subsequent schema version checks will pass (assuming they don't actually change the released schema).