Remove labels from builders and deployers #4485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4485 +/- ##
==========================================
+ Coverage 72.26% 72.42% +0.15%
==========================================
Files 331 333 +2
Lines 12863 12886 +23
==========================================
+ Hits 9296 9333 +37
+ Misses 2975 2957 -18
- Partials 592 596 +4
Continue to review full report at Codecov.
|
dgageot
suggested changes
Jul 17, 2020
|
@dgageot thanks for the review, I addressed your comments. travis is being silly today though |
|
something very strange is going on with travis. seems like it's using an old commit, I think there might be a caching bug? tests are passing for me locally and the syntax errors it's giving in the linter/windows unit/integration partitions don't match up with my latest branch. going to close this PR and reopen it as is 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3133
second attempt after #4466
this removes all labels set by skaffold except for
skaffold.dev/run-id, andapp.kubernetes.io/managed-by=skaffold. this does remove the version from the managed-by label though, so changing skaffold version will not cause issues.because we don't apply labels from build or deploy, we can remove this from their interfaces, as well as remove passing an array of
Labellers toDeployandRender. the labels are computed once when the runner is created, and stored inside the deployer.