Extend skaffold debug integration tests to buildpacks
#4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends integration tests to test `debug` with GCP Buildpacks using both Procfiles and the new project.toml.
briandealwis
requested review from
chanseokoh,
loosebazooka and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4352 +/- ##
==========================================
- Coverage 71.76% 71.71% -0.05%
==========================================
Files 324 324
Lines 12512 12514 +2
==========================================
- Hits 8979 8975 -4
- Misses 2965 2969 +4
- Partials 568 570 +2
Continue to review full report at Codecov.
|
dgageot
approved these changes
Jun 19, 2020
| configurations: | ||
|
|
||
| - `skaffold.yaml` configures docker- and jib-based builders | ||
| - `skaffold-bp.yaml` configures buildpacks-based builders |
There was a problem hiding this comment.
Could you use two profiles?
integration/debug_test.go
Outdated
| args []string | ||
| deployments []string | ||
| pods []string | ||
|
|
There was a problem hiding this comment.
linter complains on the new line
briandealwis
added
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends integration tests for
debugto test building with GCP Buildpacks using both Procfiles and the new project.toml. We reuse the existing test projects rather than define new projects. Like the existing tests, it continues to check that the language debugging runtimes are enabled and responding.These tests verify that pods and deployments are annotated with the debug configuration metadata and contains the working-directory and runtime. These annotations are used to drive the
DebuggingContainerEventevent.Other changes:
jibtests tojavasince the buildpacks mode doesn't use Jib.check-jdwp.shscript to be placed in/workspace/scriptsto be in the same place with both Jib and Buildpacks images.