Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Faster Makefile" #3716

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Revert "Faster Makefile" #3716

merged 1 commit into from
Feb 21, 2020

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Feb 21, 2020

Reverts #3706

this broke the release build because it's doing a make cross when building the binary for the docker image, which fails. reverting so I can release and then we can figure out how to fix.

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #3716 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@nkubala nkubala merged commit bb32460 into master Feb 21, 2020
@briandealwis briandealwis deleted the revert-3706-faster-make branch April 14, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants