Reduce default status check deadline to 2 mins #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
changed the title
Codecov Report
|
dgageot
suggested changes
Feb 17, 2020
| @@ -110,7 +113,7 @@ func getDeployments(client kubernetes.Interface, ns string, l *DefaultLabeller, | |||
| deployments := make([]Resource, 0, len(deps.Items)) | |||
| for _, d := range deps.Items { | |||
| var deadline time.Duration | |||
| if d.Spec.ProgressDeadlineSeconds == nil || *d.Spec.ProgressDeadlineSeconds > int32(deadlineDuration.Seconds()) { | |||
| if d.Spec.ProgressDeadlineSeconds == nil { | |||
| deadline = deadlineDuration | |||
| } else { | |||
| deadline = time.Duration(*d.Spec.ProgressDeadlineSeconds) * time.Second | |||
There was a problem hiding this comment.
i dont understand what you mean?
Do you meant *d.Spec.ProgressDeadline * time.Second?
i see an IDE error
cannot use type int as type Duration in an assignment
and also a make error
pkg/skaffold/deploy/status_check.go:119:47: invalid operation: *d.Spec.ProgressDeadlineSeconds * time.Second (mismatched types int32 and time.Duration)
There was a problem hiding this comment.
My bad. Only works with constants
|
@dgageot Addressed your comments. Please take another look. |
dgageot
approved these changes
Feb 20, 2020
| @@ -110,7 +113,7 @@ func getDeployments(client kubernetes.Interface, ns string, l *DefaultLabeller, | |||
| deployments := make([]Resource, 0, len(deps.Items)) | |||
| for _, d := range deps.Items { | |||
| var deadline time.Duration | |||
| if d.Spec.ProgressDeadlineSeconds == nil || *d.Spec.ProgressDeadlineSeconds > int32(deadlineDuration.Seconds()) { | |||
| if d.Spec.ProgressDeadlineSeconds == nil { | |||
| deadline = deadlineDuration | |||
| } else { | |||
| deadline = time.Duration(*d.Spec.ProgressDeadlineSeconds) * time.Second | |||
There was a problem hiding this comment.
My bad. Only works with constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3638, #176
In this PR, we decrease the default Status check deadline to 3 seconds.
In this changes
statusCheckDeadlineSecondsis present in the skaffold deploy config, respect that.progressDeadlineSecondsinDeployment.SpecdefaultStatusCheckDeadline