Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a hidden flag for simpler access to new init format #3660

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Feb 6, 2020

Fixes #3655.

@balopat balopat changed the title simpler new init format a hidden flag for simpler access to new init format Feb 6, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #3660 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/json.go 88.88% <100%> (ø) ⬆️
pkg/skaffold/initializer/init.go 64.81% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/init.go 100% <100%> (ø) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️
pkg/skaffold/initializer/analyze.go 87.75% <0%> (-0.49%) ⬇️
pkg/skaffold/build/buildpacks/logger.go 0% <0%> (ø) ⬆️
pkg/skaffold/event/event.go 92.94% <0%> (+0.02%) ⬆️
pkg/skaffold/build/buildpacks/lifecycle.go 75% <0%> (+3.57%) ⬆️

@@ -63,6 +63,7 @@ type Config struct {
EnableBuildpacksInit bool
BuildpacksBuilder string
Opts config.SkaffoldOptions
EnableNewInitFormat bool
Copy link
Contributor

@jonjohnsonjr jonjohnsonjr Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/skaffold/initializer/init.go:54:13: struct of size 400 bytes could be of size 392 bytes (maligned)
type Config struct {

This linter is pedantic! I love it! You can save 4 bytes by moving this up with the other bools.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, right, this always gets me

@tejal29
Copy link
Contributor

tejal29 commented Feb 7, 2020

In future, do you have plans to mark XXenableJibInit and XXenableBuildpacksInit as deprecated and use the new flag instead and convey it to IDEs?

Edit:
Looks like they are used later in detectBuilder for other purpose. There are too many flags now and we should condense them.

Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tejal29 tejal29 merged commit 12581fe into GoogleContainerTools:master Feb 7, 2020
@balopat
Copy link
Contributor Author

balopat commented Feb 7, 2020

In future, do you have plans to mark XXenableJibInit and XXenableBuildpacksInit as deprecated and use the new flag instead and convey it to IDEs?

Edit:
Looks like they are used later in detectBuilder for other purpose. There are too many flags now and we should condense them.

yeah, they are used separately.
I expect these all to disappear soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Flag for new skaffold init --analyze format
4 participants