-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a hidden flag for simpler access to new init format #3660
Conversation
Codecov Report
|
pkg/skaffold/initializer/init.go
Outdated
@@ -63,6 +63,7 @@ type Config struct { | |||
EnableBuildpacksInit bool | |||
BuildpacksBuilder string | |||
Opts config.SkaffoldOptions | |||
EnableNewInitFormat bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg/skaffold/initializer/init.go:54:13: struct of size 400 bytes could be of size 392 bytes (maligned)
type Config struct {
This linter is pedantic! I love it! You can save 4 bytes by moving this up with the other bool
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah, right, this always gets me
In future, do you have plans to mark Edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
yeah, they are used separately. |
Fixes #3655.