Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nilpointer with skaffold init --skip-build #3657

Merged
merged 1 commit into from
Feb 6, 2020
Merged

fix nilpointer with skaffold init --skip-build #3657

merged 1 commit into from
Feb 6, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Feb 6, 2020

Fixes #3650.

@codecov
Copy link

codecov bot commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #3657 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/analyze.go 87.75% <100%> (-0.49%) ⬇️

@tejal29 tejal29 self-assigned this Feb 6, 2020
@nkubala nkubala merged commit 4423935 into GoogleContainerTools:master Feb 6, 2020
@dgageot dgageot mentioned this pull request Feb 20, 2020
Closed
@fmotrifork fmotrifork mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@tejal29 tejal29 tejal29 approved these changes

@dgageot dgageot Awaiting requested review from dgageot

Assignees

@tejal29 tejal29

Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skaffold init --skip-build error
4 participants
@balopat @tejal29 @nkubala @googlebot