Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable jib feature minimum requirements #3628

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

loosebazooka
Copy link
Member

also updates the jib sync search string

Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about configuring version for all actions.

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #3628 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/build/jib/gradle.go 100% <100%> (ø) ⬆️
pkg/skaffold/build/jib/maven.go 100% <100%> (ø) ⬆️
pkg/skaffold/build/jib/sync.go 50.98% <100%> (ø) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

also updates the jib sync search string
@balopat balopat merged commit 2f7ca2d into master Feb 3, 2020
@briandealwis briandealwis deleted the jib-sync-parts-4 branch April 14, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants