Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unimplemented 'skaffold render' command #2942

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Sep 25, 2019

Relates to #1187

This adds a new command, skaffold render, which will run builds for all artifacts, tag the images, and then output the templated kubernetes manifests to the user rather than actually running the deploy. The manifests are written to stdout by default, but a --output flag can be passed to provide a filename for them to be written to. These manifests can be manually applied by the user if desired, or committed to a repository for use in CI/CD or GitOps workflows.

This does not add implementations for any deployers. Those will come in follow up PRs.

This also adds a flag, --render-only to skaffold dev and skaffold run, which will exhibit the same behavior as skaffold render (though in dev mode it will continuously print the templated manifests after each successful build).

By default, the logs and output for the builds are suppressed, but can be displayed using a --loud flag.

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #2942 into master will decrease coverage by 0.08%.
The diff coverage is 37.5%.

Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 0% <ø> (ø) ⬆️
pkg/skaffold/config/options.go 100% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <ø> (ø) ⬆️
pkg/skaffold/runner/render.go 0% <0%> (ø)
pkg/skaffold/runner/deploy.go 66.66% <0%> (-7.02%) ⬇️
cmd/skaffold/app/cmd/cmd.go 68.25% <100%> (+0.25%) ⬆️
cmd/skaffold/app/cmd/render.go 42.1% <42.1%> (ø)

@nkubala nkubala merged commit 667bd76 into GoogleContainerTools:master Sep 25, 2019
@nkubala nkubala deleted the render-command branch September 25, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants