-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update a deployment health check status only its changed. #2865
Merged
tejal29
merged 10 commits into
GoogleContainerTools:master
from
tejal29:add_reported_since
Sep 12, 2019
Merged
Update a deployment health check status only its changed. #2865
tejal29
merged 10 commits into
GoogleContainerTools:master
from
tejal29:add_reported_since
Sep 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into refactor-break-2
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
September 12, 2019 01:08
kokoko failure due to jib grade cyclic dependency:
|
tejal29
force-pushed
the
add_reported_since
branch
from
September 12, 2019 02:09
37ab2d5
to
c0bf9af
Compare
tejal29
force-pushed
the
add_reported_since
branch
from
September 12, 2019 02:10
c0bf9af
to
98c8ff1
Compare
Codecov Report
|
balopat
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #176
In this PR,
No user affecting changes.
Add 2 methods to Deployment to