Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a deployment health check status only its changed. #2865

Merged
merged 10 commits into from
Sep 12, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 12, 2019

relates to #176

In this PR,

No user affecting changes.

Add 2 methods to Deployment to

  1. ReportLastSinceUpdated will return status if its updated.
  2. Updated will only update status if it was changed.

@tejal29
Copy link
Contributor Author

tejal29 commented Sep 12, 2019

kokoko failure due to jib grade cyclic dependency:

            FAILURE: Build failed with an exception.
            
            * What went wrong:
            A problem occurred configuring root project 'workspace'.
            > Could not resolve all artifacts for configuration ':classpath'.
               > Could not resolve com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava.
                 Required by:
                     project : > com.google.cloud.tools.jib:com.google.cloud.tools.jib.gradle.plugin:1.5.0 > gradle.plugin.com.google.cloud.tools:jib-gradle-plugin:1.5.0 > com.google.guava:guava:28.0-jre
                  > Skipped due to earlier error
               > Could not resolve org.codehaus.mojo:animal-sniffer-annotations:1.17.
                 Required by:
                     project : > com.google.cloud.tools.jib:com.google.cloud.tools.jib.gradle.plugin:1.5.0 > gradle.plugin.com.google.cloud.tools:jib-gradle-plugin:1.5.0 > com.google.guava:guava:28.0-jre
                  > Could not resolve org.codehaus.mojo:animal-sniffer-annotations:1.17.
                     > Could not parse POM https://plugins.gradle.org/m2/org/codehaus/mojo/animal-sniffer-annotations/1.17/animal-sniffer-annotations-1.17.pom
                        > Could not resolve org.codehaus.mojo:animal-sniffer-parent:1.17.
                           > Could not resolve org.codehaus.mojo:animal-sniffer-parent:1.17.
                              > Could not get resource 'https://plugins.gradle.org/m2/org/codehaus/mojo/animal-sniffer-parent/1.17/animal-sniffer-parent-1.17.pom'.
                                 > Could not GET 'https://plugins.gradle.org/m2/org/codehaus/mojo/animal-sniffer-parent/1.17/animal-sniffer-parent-1.17.pom'.
                                    > Read timed out
               > Could not resolve io.grpc:grpc-context:1.19.0.
                 Required by:
                     project : > com.google.cloud.tools.jib:com.google.cloud.tools.jib.gradle.plugin:1.5.0 > gradle.plugin.com.google.cloud.tools:jib-gradle-plugin:1.5.0 > com.google.http-client:google-http-client:1.31.0 > io.opencensus:opencensus-api:0.21.0
                  > Skipped due to earlier error
            
            * Try:
            Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
            
            * Get more help at https://help.gradle.org
            
            BUILD FAILED in 1m 1s
            ERROR
            ERROR: build step 0 "gcr.io/cloud-builders/gradle" failed: exit status 1

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #2865 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/resource/status.go 100% <100%> (ø) ⬆️
pkg/skaffold/deploy/resource/deployment.go 100% <100%> (ø) ⬆️

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejal29 tejal29 merged commit 93b65da into GoogleContainerTools:master Sep 12, 2019
@tejal29 tejal29 deleted the add_reported_since branch September 18, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants