Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource.Status object and remove sync.Map #2851

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 10, 2019

Relates to #176

Add a resource.Status struct which stores the status of the deployment in Deployment.status field.

Remove sync.Map which was used to deployments status.

Output changes:

  • No output changes.

Next PRs:

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #2851 into master will increase coverage by 0.03%.
The diff coverage is 79.31%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/resource/deployment.go 100% <100%> (ø) ⬆️
pkg/skaffold/deploy/resource/status.go 60% <60%> (ø)
pkg/skaffold/deploy/status_check.go 64.04% <81.81%> (+1.82%) ⬆️

@balopat balopat merged commit 770ccce into GoogleContainerTools:master Sep 10, 2019
@tejal29 tejal29 deleted the add_resource_status branch September 18, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants