Add missing digest when setting helm image tag #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakowski
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
The helm deployer did not append the digest during deployment, which caused file sync and log output (and maybe other features) to stop working. (GoogleContainerTools#1379)
krakowski
force-pushed
the
hotfix/1379/helm-tag
branch
from
701e3ab to
b02733b
Compare
Codecov Report
|
|
@krakowski Thank you for your PR. I restarted the travis build. test failures looked like some flakes. Thanks |
tejal29
approved these changes
Aug 9, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The helm deployer did not append the digest during deployment,
which caused file sync and log output (and maybe other features)
to stop working.
Explanation
As you can see in the screenshot,
dockerRef.Tag(which does not contain the digest) is used for setting the image tag (line 192 and 195) if theimageStrategyis set tohelm. If theimageStrategyis not set tohelmthe deployer usesv.Tagwhich contains the registry location, the repository name and the tag (including the digest).Issues
Fixes #1379
Related