Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --render options for skaffold deploy. #1739

Closed
tejal29 opened this issue Mar 6, 2019 · 4 comments
Closed

Support --render options for skaffold deploy. #1739

tejal29 opened this issue Mar 6, 2019 · 4 comments

Comments

@tejal29
Copy link
Contributor

tejal29 commented Mar 6, 2019

In #1737 @andsens mentioned, pointed out a use case where users would want to inspect skaffold deploy generated manifests.

I am thinking this would also be required for

Expected behavior

when you run skaffold with --dryrun flag, all the manifests it generates should be dumped in ./out directory.

Actual behavior

Right now, users need to run skaffold with -v=debug flag to grab the generated manifests from output.

Information

  • Skaffold version: v0.5.0-1901-g1d077079-dirty
  • Operating system: ...
  • Contents of skaffold.yaml:
<paste your skaffold.yaml here>

Steps to reproduce the behavior

@nkubala
Copy link
Contributor

nkubala commented Mar 6, 2019

now that we've separated out the tagging interface and gotten rid of the "unstable" taggers, this should be possible. dry run mode for skaffold build would give the user the images skaffold would have built, though for skaffold deploy we'll need to rethink it (or possibly just address #922 first).

dry run mode for skaffold run would probably provide the user with both the images that would have been built as well as the templated manifests, and skaffold dev would do the same thing (no dev loop).

@alnr
Copy link

alnr commented Jul 8, 2019

Note you can pass the --dry-run flag to your deployer of choice, but output is interleaved with skaffold logging (see #1937 (comment))

@tejal29
Copy link
Contributor Author

tejal29 commented Aug 21, 2019

I think we should add a flag to deploy to dump the manifests generated as mentioned

@tejal29 tejal29 changed the title Support --dryrun options for skaffold build, skaffold deploy and potentially others. Support --render options for skaffold deploy. Aug 21, 2019
@tejal29 tejal29 added area/ci-cd priority/p1 High impact feature/bug. labels Aug 21, 2019
@tejal29
Copy link
Contributor Author

tejal29 commented Sep 6, 2019

Related to #1187
Closing this as its dupe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants