Merge pull request #3722 from balopat/fix_analyze_update_check

Fix analyze update check
GoogleContainerTools · Feb 24, 2020 · c96b1f8 · c96b1f8
2 parents 918b78e + 1331d1c
commit c96b1f8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/cmd/skaffold/app/cmd/cmd.go b/cmd/skaffold/app/cmd/cmd.go
@@ -98,16 +98,18 @@ func NewSkaffoldCommand(out, err io.Writer) *cobra.Command {
 			logrus.Infof("Skaffold %+v", version)
 			event.LogSkaffoldMetadata(version)
 
-			if quietFlag {
+			switch {
+			case quietFlag:
 				logrus.Debugf("Update check is disabled because of quiet mode")
-			} else {
+			case analyze:
+				logrus.Debugf("Update check is disabled because of init --analyze")
+			default:
 				go func() {
 					if err := updateCheck(updateMsg, opts.GlobalConfig); err != nil {
 						logrus.Infof("update check failed: %s", err)
 					}
 				}()
 			}
-
 			return nil
 		},
 		PersistentPostRun: func(cmd *cobra.Command, args []string) {

diff --git a/pkg/skaffold/update/update.go b/pkg/skaffold/update/update.go
@@ -24,6 +24,7 @@ import (
 
 	"github.com/blang/semver"
 	"github.com/pkg/errors"
+	"github.com/sirupsen/logrus"
 
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/config"
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/constants"
@@ -65,6 +66,7 @@ func getLatestAndCurrentVersion() (semver.Version, semver.Version, error) {
 	if err != nil {
 		return none, none, err
 	}
+	logrus.Tracef("latest skaffold version: %s", versionString)
 	latest, err := version.ParseVersion(versionString)
 	if err != nil {
 		return none, none, errors.Wrap(err, "parsing latest version from GCS")