Create issues for status-check for debug and microservices

GoogleContainerTools · Jun 28, 2019 · 3d33a93 · 3d33a93
1 parent 0740931
commit 3d33a93
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/integration/debug_test.go b/integration/debug_test.go
@@ -41,13 +41,16 @@ func TestDebug(t *testing.T) {
 	}{
 		{
 			description: "kubectl",
+			// see https://github.com/GoogleContainerTools/skaffold/issues/2373
 			dir:         "testdata/debug",
+			args:        []string{"--status-check=false"},
 			deployments: []string{"jib"},
 			pods:        []string{"nodejs", "npm", "python3"},
 		},
 		{
 			description: "kustomize",
-			args:        []string{"--profile", "kustomize"},
+			// See https://github.com/GoogleContainerTools/skaffold/issues/2373
+			args:        []string{"--profile", "kustomize", "--status-check=false"},
 			dir:         "testdata/debug",
 			deployments: []string{"jib"},
 			pods:        []string{"nodejs", "npm", "python3"},

diff --git a/integration/deploy_test.go b/integration/deploy_test.go
@@ -68,7 +68,8 @@ func TestBuildDeploy(t *testing.T) {
 	dir.Write("build.out", string(outputBytes))
 
 	// Run Deploy using the build output
-	skaffold.Deploy("--build-artifacts", buildOutputFile).InDir("examples/microservices").InNs(ns.Name).RunOrFail(t)
+	// See https://github.com/GoogleContainerTools/skaffold/issues/2372 on why status-check=false
+	skaffold.Deploy("--build-artifacts", buildOutputFile, "--status-check=false").InDir("examples/microservices").InNs(ns.Name).RunOrFail(t)
 
 	depApp := client.GetDeployment("leeroy-app")
 	testutil.CheckDeepEqual(t, appTag, depApp.Spec.Template.Spec.Containers[0].Image)

diff --git a/integration/run_test.go b/integration/run_test.go
@@ -52,6 +52,8 @@ func TestRun(t *testing.T) {
 		}, {
 			description: "microservices",
 			dir:         "examples/microservices",
+			// See https://github.com/GoogleContainerTools/skaffold/issues/2372
+			args:        []string{"--status-check=false"},
 			deployments: []string{"leeroy-app", "leeroy-web"},
 		}, {
 			description: "envTagger",