Fix return of error adding artifacts to cache when images are built r…

…emotely (#4850)

* Fix return of error when images are built remotely

* Remove unnecessary leading newline

* Simplify func addArtifacts

pkg/skaffold/build/cache/retrieve.go

@@ -149,29 +149,25 @@ func maintainArtifactOrder(built []build.Artifact, artifacts []*latest.Artifact)
 func (c *cache) addArtifacts(ctx context.Context, bRes []build.Artifact, hashByName map[string]string) error {
 	for _, a := range bRes {
 		entry := ImageDetails{}
+		if c.imagesAreLocal {
+			imageID, err := c.client.ImageID(ctx, a.Tag)
+			if err != nil {
+				return err
+			}
 
-		if !c.imagesAreLocal {
+			if imageID != "" {
+				entry.ID = imageID
+			}
+		} else {
 			ref, err := docker.ParseReference(a.Tag)
 			if err != nil {
 				return fmt.Errorf("parsing reference %q: %w", a.Tag, err)
 			}
-
 			entry.Digest = ref.Digest
 		}
-
-		imageID, err := c.client.ImageID(ctx, a.Tag)
-		if err != nil {
-			return err
-		}
-
-		if imageID != "" {
-			entry.ID = imageID
-		}
-
 		c.cacheMutex.Lock()
 		c.artifactCache[hashByName[a.ImageName]] = entry
 		c.cacheMutex.Unlock()
 	}
-
 	return nil
 }