make manifests.Load return the error too

cmd/skaffold/app/cmd/filter.go

@@ -18,6 +18,7 @@ package cmd
 
 import (
 	"context"
+	"fmt"
 	"io"
 	"os"
 
@@ -59,24 +60,27 @@ func NewCmdFilter() *cobra.Command {
 // Unlike `skaffold debug`, this filtering affects all images and not just the built artifacts.
 func runFilter(ctx context.Context, out io.Writer, debuggingFilters bool, buildArtifacts []build.Artifact) error {
 	return withRunner(ctx, func(r runner.Runner, cfg *latest.SkaffoldConfig) error {
-		manifestList := manifest.Load(os.Stdin)
+		manifestList, err := manifest.Load(os.Stdin)
+		if err != nil {
+			return fmt.Errorf("loading manifests: %w", err)
+		}
 		if debuggingFilters {
 			// TODO(bdealwis): refactor this code
 			debugHelpersRegistry, err := config.GetDebugHelpersRegistry(opts.GlobalConfig)
 			if err != nil {
-				return err
+				return fmt.Errorf("resolving debug helpers: %w", err)
 			}
 			insecureRegistries, err := getInsecureRegistries(opts, cfg)
 			if err != nil {
-				return err
+				return fmt.Errorf("retrieving insecure registries: %w", err)
 			}
 
 			manifestList, err = debugging.ApplyDebuggingTransforms(manifestList, buildArtifacts, manifest.Registries{
 				DebugHelpersRegistry: debugHelpersRegistry,
 				InsecureRegistries:   insecureRegistries,
 			})
 			if err != nil {
-				return err
+				return fmt.Errorf("transforming manifests: %w", err)
 			}
 		}
 		out.Write([]byte(manifestList.String()))

pkg/skaffold/kubernetes/manifest/manifests.go

@@ -31,17 +31,19 @@ import (
 type ManifestList [][]byte
 
 // Load uses the Kubernetes `apimachinery` to split YAML content into a set of YAML documents.
-func Load(in io.Reader) ManifestList {
+func Load(in io.Reader) (ManifestList, error) {
 	r := k8syaml.NewYAMLReader(bufio.NewReader(in))
 	var docs [][]byte
-	for i := 0; ; i++ {
+	for {
 		doc, err := r.Read()
 		if err == io.EOF {
 			break
+		} else {
+			return nil, err
 		}
 		docs = append(docs, doc)
 	}
-	return ManifestList(docs)
+	return ManifestList(docs), nil
 }
 
 func (l *ManifestList) String() string {

pkg/skaffold/kubernetes/manifest/manifests_test.go

@@ -35,8 +35,9 @@ func TestLoad(t *testing.T) {
 	}
 	for _, test := range tests {
 		testutil.Run(t, test.name, func(t *testutil.T) {
-			result := Load(bytes.NewReader([]byte(test.input)))
+			result, err := Load(bytes.NewReader([]byte(test.input)))
 
+			t.CheckError(false, err)
 			t.CheckDeepEqual(len(test.expected), len(result))
 			for i := range test.expected {
 				t.CheckDeepEqual(test.expected[i], string(result[i]))