remove flaky test for incorrect deployment

integration/deploy_test.go

@@ -17,7 +17,6 @@ limitations under the License.
 package integration
 
 import (
-	"strings"
 	"testing"
 
 	"github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/flags"
@@ -110,13 +109,10 @@ func TestDeployWithInCorrectConfig(t *testing.T) {
 	ns, _, deleteNs := SetupNamespace(t)
 	defer deleteNs()
 
-	out, err := skaffold.Deploy().InDir("testdata/unstable-deployment").InNs(ns.Name).RunWithOutput(t)
+	err := skaffold.Deploy().InDir("testdata/unstable-deployment").InNs(ns.Name).Run(t)
 	if err == nil {
 		t.Error("expected an error to see since the deployment is not stable. However deploy returned success")
 	}
-	if !strings.Contains(string(out), "exceeded its progress deadline") {
-		t.Errorf("expected to see message :exceeded progress deadline error. however saw this error %s", string(out))
-	}
 
 	skaffold.Delete().InDir("testdata/unstable-deployment").InNs(ns.Name).RunOrFail(t)
 }

integration/skaffold/helper.go

@@ -172,24 +172,6 @@ func (b *RunBuilder) Run(t *testing.T) error {
 	return nil
 }
 
-// RunWithOutput runs the skaffold command with output.
-func (b *RunBuilder) RunWithOutput(t *testing.T) ([]byte, error) {
-	t.Helper()
-
-	cmd := b.cmd(context.Background())
-	cmd.Stdout, cmd.Stderr = nil, nil
-	logrus.Infoln(cmd.Args)
-
-	start := time.Now()
-	out, err := cmd.Output()
-	if err != nil {
-		return out, errors.Wrapf(err, "skaffold %s", b.command)
-	}
-
-	logrus.Infoln("Ran in", time.Since(start))
-	return out, nil
-}
-
 // RunOrFailOutput runs the skaffold command and fails the test
 // if the command returns an error.
 // It only returns the standard output.