feat: refactor set-image with go sdk
#904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyy98
requested review from
droot,
mengqiy,
sdowell and
yuwenma
as code owners
zyy98
commented
Aug 12, 2022
zyy98
commented
Aug 12, 2022
zyy98
commented
Aug 12, 2022
yuwenma
reviewed
Aug 12, 2022
yuwenma
reviewed
Aug 12, 2022
yuwenma
reviewed
Aug 12, 2022
yuwenma
reviewed
Aug 12, 2022
yuwenma
reviewed
Aug 12, 2022
yuwenma
reviewed
Aug 12, 2022
yuwenma
reviewed
Aug 12, 2022
yuwenma
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Haven't checked the unittests. Two major areas to consider:
- fn.Result seems to be redundant, can you either use existing functions (e.g.
ConfigObjectResult) or develop something new in the sdk? - it seems that there are some duplicated code, e.g.
validateInput, shall we cleanup them? FYI, to keepadditionalFields, I'm expecting that we can completely separate the solutions using kyaml lib and the go sdk lib. The pseudo code can be like
parse input yaml --> initializeimageTransformer--> transform configs from A to B -->additionalFielddetected --> initialize the kyaml filters and other objects --> transform modified config B to C --> log results.
yuwenma
suggested changes
Aug 16, 2022
yuwenma
reviewed
Aug 18, 2022
# Conflicts: # functions/go/set-image/image_transformer_test.go # functions/go/set-image/main.go # functions/go/set-image/transformer/images.go
yuwenma
reviewed
Aug 29, 2022
yuwenma
reviewed
Aug 29, 2022
yuwenma
reviewed
Aug 29, 2022
yuwenma
reviewed
Aug 29, 2022
yuwenma
reviewed
Aug 29, 2022
yuwenma
approved these changes
Aug 30, 2022
zyy98
changed the title
set-image with go sdkset-image with go sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issues kptdev/kpt#3444
Start by refactoring
set-imagefunctions using go-sdk package.Additional changes:
Allow both
digestandtagset in input.To test
Runnerinterface, replace unit tests with end-to-end tests.