support to pull base images from insecure registries.

[everpeace]

Motivation

We operate an insecure docker registry and kubernetes cluster in on-premise environment. kaniko can push container images to the insecure registry. But, can't pull from the insecure registry.

How

make --insecure-skip-tls-verify be able to affect when pulling images.

Because user should be able to use multi stage build, with this option, it tries to connect to a registry in secure way first. Only when it failed, it will switch to connect insecure mode.

[container-tools-bot]

Hi @everpeace. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dlorenc]

I'd be fine with just using the same DockerInsecureSkipTLSVerify flag for both of these, WDYT?

[everpeace]

I'd be fine too. I'll fix it 👍

[everpeace]

@dlorenc I changed to re-use --insecure-skip-tls-verify for pulling from insecure registries.

and I squashed my commits. Would you mind taking a look again?

[dlorenc]

Looked like an IO timeout, I'll retry the test run.

[priyawadhwa]

Hey @everpeace, this needs a rebase.

[priyawadhwa]

Hey @everpeace, with #409 kaniko supports pulling and pushing from insecure registries. I'll go ahead and close this PR.

[everpeace]

Thnaks, actually dtaniwaki is my colleague :-)