-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade docker #2440
Merged
imjasonh
merged 9 commits into
GoogleContainerTools:main
from
joe-kimmel-vmw:upgrade-docker2
Mar 24, 2023
Merged
Upgrade docker #2440
imjasonh
merged 9 commits into
GoogleContainerTools:main
from
joe-kimmel-vmw:upgrade-docker2
Mar 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Joe Kimmel <[email protected]>
Signed-off-by: Joe Kimmel <[email protected]>
…are still failing Signed-off-by: Joe Kimmel <[email protected]>
Signed-off-by: Joe Kimmel <[email protected]>
joe-kimmel-vmw
force-pushed
the
upgrade-docker2
branch
from
March 23, 2023 01:26
aab0f1e
to
41c7c5e
Compare
Signed-off-by: Joe Kimmel <[email protected]>
Signed-off-by: Joe Kimmel <[email protected]>
Signed-off-by: Joe Kimmel <[email protected]>
…the file Signed-off-by: Joe Kimmel <[email protected]>
Signed-off-by: Joe Kimmel <[email protected]>
imjasonh
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades docker version (should close #2370 after merging)
Description
Turns out Cloud Native Buildpacks, downstream of yall, would really like to upgrade our docker version, but that's goingt o be easier if you-all do it too. I think this is basically because golang likes to pretend we all work in a monorepo of a certain larGe co. where all deps get bumped at once?
Note - I want to make this PR,- there's still 2 unit tests failing locally that seem unrelated (one of them wants GCP creds? and one of them I can't figure out why it's failing), anyways I want to see how much of the unit test suite passes in CI and whether there's other tests that need to be fixed in integration land.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
bumps docker to v23 and updates many other libraries as well.