Fixes #1837 : keep file capabilities on archival #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypnoce
force-pushed
the
add_security_capability
branch
4 times, most recently
from
caa54c4
to
6534a68
Compare
|
All check failed with Rebased |
hypnoce
force-pushed
the
add_security_capability
branch
from
6534a68
to
680aa93
Compare
|
@imjasonh I rebased, hope it fixes the builds. |
hypnoce
force-pushed
the
add_security_capability
branch
from
680aa93
to
fb8a934
Compare
|
Kaniko should also keep security xattr when unpacking. Added the writeXattr when unpacking. |
hypnoce
force-pushed
the
add_security_capability
branch
from
fb8a934
to
236096b
Compare
Signed-off-by: JACQUES Francois <[email protected]>
hypnoce
force-pushed
the
add_security_capability
branch
from
236096b
to
53bfd6c
Compare
gcalmettes
pushed a commit
to gcalmettes/kaniko
that referenced
this pull request
Dec 24, 2021
…oogleContainerTools#1838) Signed-off-by: JACQUES Francois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1837
Description
Read
security.capabilityfrom file and store it in XAttrs tar header.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Preserve file capabilities on archival