Fix BuildTarTask input files to also include main SourceSet outputs #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahh thanks for this reminder! Will update changelog and merge. |
|
Kudos, SonarCloud Quality Gate passed! |
mpeddada1
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3666.
It looks like this issue was introduced when making the switch to custom configurations in #3034. The previous use of
mainSourceSet.getRuntimeClasspath()also included class and resource outputs for the mainSourceSetthat are now missed, so changes to the Java classes are no longer getting picked up as Gradle task inputs.This PR adds back the
mainSourceSet’s outputs to GradleProjectPriperties.getInputFiles(). (Perhaps this will need to be updated ifSourceSetis ever made configurable, but currently this fix is consistent with the previous behavior of usingmain.)