Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gradle Property and Provider to enable lazy evaluation for jib.extraDirectories parameters #3737

Merged
merged 24 commits into from
Aug 25, 2022
Merged

Use Gradle Property and Provider to enable lazy evaluation for jib.extraDirectories parameters #3737

merged 24 commits into from
Aug 25, 2022

Commits on Aug 16, 2022

  1. Update permissions type from Map to MapProperty

    @emmileaf
    emmileaf committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    a55e53a View commit details
    Browse the repository at this point in the history

  2. Convert path.from and path.into to property types

    @emmileaf
    emmileaf committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    019fd65 View commit details
    Browse the repository at this point in the history

  3. WIP: add/fix unit tests

    @emmileaf
    emmileaf committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3402b29 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. WIP: changes to setFrom to accept Provider type

    @emmileaf
    emmileaf committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    63319af View commit details
    Browse the repository at this point in the history

  2. WIP: comment out added tests for more debugging

    @emmileaf
    emmileaf committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5e6f237 View commit details
    Browse the repository at this point in the history

  3. WIP: clean up updated setFrom to allow for lazy eval

    @emmileaf
    emmileaf committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    a5f1aee View commit details
    Browse the repository at this point in the history

  4. WIP: fix added unit test, can lazy eval using setFrom but not setPaths

    @emmileaf
    emmileaf committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    56cb69e View commit details
    Browse the repository at this point in the history

  5. Add extra directories to lazy evaluation testing project

    @emmileaf
    emmileaf committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    b43c295 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Switch setFrom to method overloading

    @emmileaf
    emmileaf committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    7370713 View commit details
    Browse the repository at this point in the history

  2. Update setPaths to allow for lazy eval

    @emmileaf
    emmileaf committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    1360011 View commit details
    Browse the repository at this point in the history

  3. Update unit tests to check for both specification options

    @emmileaf
    emmileaf committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    1819eb3 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Remove setPermissions test

    @emmileaf
    emmileaf committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    b2815b7 View commit details
    Browse the repository at this point in the history

  2. Fix file formatting

    @emmileaf
    emmileaf committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    798882d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Switch from anonymous inner classes to lambdas

    @emmileaf
    emmileaf committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b79d5ec View commit details
    Browse the repository at this point in the history

  2. Fix test compatibility with windows

    @emmileaf
    emmileaf committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    925d5c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Coverage: add tests for extraDirectories in JibExtensionTest

    @emmileaf
    emmileaf committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    af4bb2c View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Rename test file for committing test extra directory

    @emmileaf
    emmileaf committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    4d986fa View commit details
    Browse the repository at this point in the history

  2. Update changelog and readme

    @emmileaf
    emmileaf committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    bd9183d View commit details
    Browse the repository at this point in the history

  3. Move object to parameters logic into helper method

    @emmileaf
    emmileaf committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    11d9dd1 View commit details
    Browse the repository at this point in the history

  4. Fix javadoc checkstyle violations

    @emmileaf
    emmileaf committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    c7e131e View commit details
    Browse the repository at this point in the history

  5. Rename added tests 

    Co-authored-by: Mridula <[email protected]>
    @emmileaf @mpeddada1
    emmileaf and mpeddada1 authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    f380733 View commit details
    Browse the repository at this point in the history

  6. Rename helper method

    @emmileaf
    emmileaf committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    96197cf View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Updated test to use stricter assert statement for path.from

    @emmileaf
    emmileaf committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    25e47a5 View commit details
    Browse the repository at this point in the history

  2. Update test file with more informative content

    @emmileaf
    emmileaf committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    6f0a3b7 View commit details
    Browse the repository at this point in the history