Add imagePushed field to jib-image.json #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
…b.skipExistingImages option is in use.
wwadge
force-pushed
the
add-image-pushed
branch
from
e33ee88
to
bfa02f7
Compare
|
@mpeddada1, can you please have a look at this? |
|
Thank you for your contribution @wwadge! We need a couple of days to review your PR. We appreciate your patience on this. |
mpeddada1
reviewed
May 17, 2022
...e/src/integration-test/java/com/google/cloud/tools/jib/api/ContainerizerIntegrationTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainer.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/api/JibContainerTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainer.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/BuildResult.java
Show resolved
Hide resolved
...-common/src/test/java/com/google/cloud/tools/jib/plugins/common/ImageMetadataOutputTest.java
Show resolved
Hide resolved
|
Sure! Pushed cleanups in 9663bcf |
mpeddada1
requested changes
May 23, 2022
...ugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/JibBuildRunnerTest.java
Show resolved
Hide resolved
|
Will add a few more lines to improve test coverage shortly (also noticed JibContainer missed out an update to equals) |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps track of which images were pushed onto the target registry, useful for when skipExistingImages option is in use especially in a mono-repo contest.
#3636